This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Add values for dynamic backend plugin support #111
Merged
+174
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
suggested changes
Sep 21, 2023
davidfestal
changed the title
davidfestal
force-pushed
the
dynamic-backend-plugins
branch
5 times, most recently
from
00116f6
to
dc071ef
Compare
davidfestal
force-pushed
the
dynamic-backend-plugins
branch
6 times, most recently
from
9259d0b
to
d435249
Compare
Zaperex
reviewed
Oct 24, 2023
tumido
suggested changes
Oct 24, 2023
charts/backstage/values.yaml
Outdated
| @@ -12,8 +16,12 @@ upstream: | |||
| image: | |||
| registry: quay.io | |||
| repository: janus-idp/backstage-showcase | |||
| tag: latest | |||
| tag: next | |||
There was a problem hiding this comment.
Done, but afaict that will the CI tests. Should I temporarily change the tags in [CI default values](git push origin dynamic-backend-plugins:dynamic-backend-plugins) ?
There was a problem hiding this comment.
In fact I have temporarily changed the CI test initContainer image tag to next in commit c20c21b.
With that tests should succeed.
davidfestal
force-pushed
the
dynamic-backend-plugins
branch
5 times, most recently
from
c20c21b
to
32f3493
Compare
|
Will also need to add the "integrity": {
"title": "Integrity checksum of the package. Optional for local packages. Supported algorithms include: `sha512`, `sha384` and `sha256`. Refer to https://w3c.github.io/webappsec-subresource-integrity/#integrity-metadata-description for more information",
"type": "string"
} |
davidfestal
force-pushed
the
dynamic-backend-plugins
branch
from
32f3493
to
2988a20
Compare
4 tasks
davidfestal
force-pushed
the
dynamic-backend-plugins
branch
from
0ce2e86
to
4d7a935
Compare
|
@tumido Is the PR OK for you now ? I assume we'll have to wait for the new release of the showcase before merging it ? |
tumido
suggested changes
Nov 1, 2023
5 tasks
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
dynamic-backend-plugins
branch
from
4d7a935
to
6146d64
Compare
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
dynamic-backend-plugins
branch
from
6146d64
to
fd14dc8
Compare
davidfestal
force-pushed
the
dynamic-backend-plugins
branch
from
fd14dc8
to
1bc21b2
Compare
|
@davidfestal we still need to add the integrity field into the helm chart schema since janus-idp/backstage-showcase#670 and janus-idp/backstage-showcase#704 are merged. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Festal dfestal@redhat.com
Description of the change
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.